[Sema]: improve noasync diagnostics in defer statement bodies #73841
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamieQ
force-pushed
the
diagnose-noasync-in-defer
branch
3 times, most recently
from
cb67424 to
c52314b
Compare
tshortli
reviewed
May 24, 2024
|
@swift-ci please smoke test |
updates noasync diagnostics in TypeCheckAvailability.cpp to diagnose defer bodies as if they had the same `isAsyncContext()` value as their nearest non-defer parent scope. resolves: swiftlang#73614
jamieQ
force-pushed
the
diagnose-noasync-in-defer
branch
from
c52314b to
e68c36b
Compare
tshortli
approved these changes
May 25, 2024
|
@swift-ci please test |
|
@jamieQ we'd like to take this on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updates noasync diagnostics in TypeCheckAvailability.cpp to diagnose defer bodies as if they had the same
isAsyncContext()value as their nearest non-defer parent scope.resolves: #73614 and rdar://128102432