[6.0] [IRGenDebugInfo] Fix usage of dbg.declare #73861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Snowy1803
commented
May 23, 2024
Snowy1803
commented
- Explanation: Avoid using dbg.declare in optimized code, as it can cause issues when debug values get moved around.
- Scope: Affects debug info at the IRGen level
- Original PR: [IRGenDebugInfo] Fix usage of dbg.declare #73769
- Risk: Low, only touches debug info in optimized code, and adds missing debug info in unoptimized code
- Testing: Existing tests have been updated
- Issue: rdar://128155050 and rdar://128491243
- Reviewer: @adrian-prantl
This is unnecessarily dropping debug info, as there is currently no assertion in LLVM. The sharing of stack slot can happen because of AllocStackHoisting, which is run at -Onone too. (cherry picked from commit 2726d83)
Except for the async context, where it is needed (arguments within an async function). We don't support dbg.declare in optimized code, as variables can be moved by SIL optimization passes. If a partial store is eliminated, we want a dbg.value on the allocation, and another dbg.value with a fragment in place of the partial store. rdar://128155050 (cherry picked from commit 5606fbc)
|
@swift-ci please test |
adrian-prantl
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.