Skip to content

[Build] Move the .cfg file generation to a new product. #73863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 24, 2024
Merged

[Build] Move the .cfg file generation to a new product. #73863

merged 1 commit into from
May 24, 2024

Conversation

al45tair
Copy link
Contributor

We need to move the .cfg file generation to a new product so that we can land it in the default toolchain for Xcode.

rdar://128612098

@al45tair al45tair requested a review from a team as a code owner May 23, 2024 21:42
@al45tair
Copy link
Contributor Author

al45tair commented May 23, 2024 •
edited
Loading

Explanation: Because of the way Xcode gets built, the code in llvm.py that added the .cfg files doesn't result in them showing up in the toolchain there. We need to add another product to the build scripts and trigger that in the correct places.
Original PR: #73845
Risk: Low. Adds a couple of extra files to the install directory, both of which only affect people trying to use the fully static Linux SDK. Doesn't affect anything else.
Reviewed by: @edymtt
Resolves: rdar://128612098
Tests: We're running builds to make sure the files arrive in the correct location.

@al45tair al45tair force-pushed the eng/PR-128612098-6.0 branch 6 times, most recently from b94d6d1 to a395e17 Compare May 24, 2024 07:11
@al45tair
[Build] Move the .cfg file generation to a new product.
3441323 
We need to move the `.cfg` file generation to a new product so that we can
land it in the default toolchain for Xcode.

rdar://128612098
@al45tair al45tair force-pushed the eng/PR-128612098-6.0 branch from a395e17 to 3441323 Compare May 24, 2024 07:26
@al45tair
Copy link
Contributor Author

@swift-ci Please test

@al45tair al45tair merged commit 925f715 into swiftlang:release/6.0 May 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DougGregor DougGregor DougGregor approved these changes

@edymtt edymtt edymtt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@al45tair @DougGregor @edymtt