Skip to content

[6.0] [PackageCMO] Add SerializePackageEnabled flag to Module format #73867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[6.0] [PackageCMO] Add SerializePackageEnabled flag to Module format #73867

wants to merge 1 commit into from

Conversation

elsh
Copy link
Contributor

@elsh elsh commented May 23, 2024 •
edited
Loading

  • Explanation: Add SerializePackageEnabled flag to Module format so that the set option is not lost during SIL cloning during Package CMO and can be used in SILVerifier that checks for non-resilient access.
  • Scope: Affects Package CMO only
  • Original PR: Add a package serialization bit to Module for SIL verifier in Package CMO mode. #72937
  • Risk: Low. Changes are behind a flag and only affects Package CMO.
  • Testing: Added new tests.
  • Issue: rdar://126157356&128647016
  • Reviewer: @nkcsgexi

@elsh
During Package CMO, SIL cloning happens during which
deb3d72 
SILOptions::EnableSerializePackage info is lost.

SILVerifier needs this info to determine whether resilience
can be bypassed for decls serialized in a resiliently
built module when Package CMO optimization enabled.

This PR adds SerializePackageEnabled bit to Module format
and uses that in SILVerifier.

Resolves rdar://126157356
@elsh elsh requested a review from a team as a code owner May 23, 2024 23:58
@elsh
Copy link
Contributor Author

elsh commented May 23, 2024

#73865
@swift-ci test

@elsh elsh added the swift 6.0 label May 24, 2024
This was referenced May 24, 2024
Closed
Closed
@elsh
Copy link
Contributor Author

elsh commented May 30, 2024

Included in #73993

@elsh elsh closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
swift 6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@elsh