Skip to content

[6.0] Frontend: Lift restrictions on lazy type checking options #73906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

tshortli
Copy link
Contributor

  • Explanation: The -experimental-skip-all-function-bodies flag is specified when producing modules for indexing. These modules are not used for compilation, so it should be safe to allow -experimental-lazy-typecheck and -experimental-skip-non-exportable-decls as well without -enable-library-evolution.
  • Scope: Unblocks experimentation with lazy type checking during indexing.
  • Issue/Radar: rdar://128706306
  • Original PR: Frontend: Lift restrictions on lazy type checking options #73905
  • Risk: Low. -experimental-skip-all-function-bodies is only specified during indexing, and existing build systems only pass the lazy type checking flags when a module has library evolution enabled.
  • Testing: Added a regression test.

@tshortli tshortli requested a review from bnbarham May 24, 2024 22:18
@tshortli tshortli requested a review from a team as a code owner May 24, 2024 22:18
@tshortli
Copy link
Contributor Author

@swift-ci please test

@tshortli tshortli enabled auto-merge May 25, 2024 00:55
@tshortli
Copy link
Contributor Author

@swift-ci please test macOS

@tshortli tshortli added 🍒 release cherry pick Flag: Release branch cherry picks swift 6.0 labels May 25, 2024
tshortli added 2 commits May 26, 2024 10:23
…-lazy`.

It is no longer needed to work around missing build system support.
The `-experimental-skip-all-function-bodies` flag is specified when producing
modules for indexing. These modules are not used for compilation, so it should
be safe to allow `-experimental-lazy-typecheck` and
`-experimental-skip-non-exportable-decls` as well without
`-enable-library-evolution`.

Resolves rdar://128706306
@tshortli tshortli force-pushed the allow-skip-non-exportable-with-skip-all-function-bodies-6.0 branch from c013c7f to 15a2d30 Compare May 26, 2024 17:23
@tshortli
Copy link
Contributor Author

@swift-ci please test

@tshortli
Copy link
Contributor Author

@swift-ci please test Windows

@tshortli tshortli merged commit 3993f03 into swiftlang:release/6.0 May 27, 2024
5 checks passed
@tshortli tshortli deleted the allow-skip-non-exportable-with-skip-all-function-bodies-6.0 branch May 27, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🍒 release cherry pick Flag: Release branch cherry picks swift 6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants