Skip to content

[Concurrency] Fix embedded, cannot refer to runtime/env vars from Actor.cpp #73934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2024

Conversation

ktoso
Copy link
Contributor

@ktoso ktoso commented May 28, 2024

Fixes embedded because we cannot refer to runtime / env.

@ktoso ktoso force-pushed the pick-concurrency-isCurrent-more-fixes branch 2 times, most recently from 7283fb7 to ff9b138 Compare May 28, 2024 07:36
@ktoso ktoso requested review from kubamracek, DougGregor and hborla May 28, 2024 07:37
@ktoso ktoso force-pushed the pick-concurrency-isCurrent-more-fixes branch from ff9b138 to 7c0e1f5 Compare May 28, 2024 09:20
@ktoso ktoso added the concurrency Feature: umbrella label for concurrency language features label May 28, 2024
@ktoso
Copy link
Contributor Author

ktoso commented May 28, 2024

@swift-ci please smoke test

@ktoso
Copy link
Contributor Author

ktoso commented May 29, 2024

Turns out this isn't strictly necessary on main due to #72769 which is on purpose only on main and not on 6.0, so that's why the overlap with the SWIFT_STDLIB_HAS_ENVIRON made it work over here on main by accident somewhat.

Going to merge anyway since this is more correct and we'll have the same on 6.0

@ktoso ktoso merged commit a664c02 into swiftlang:main May 29, 2024
3 checks passed
@ktoso ktoso deleted the pick-concurrency-isCurrent-more-fixes branch May 29, 2024 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
concurrency Feature: umbrella label for concurrency language features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant