Skip to content

[6.0][python] Replace deprecated assertEquals with assertEqual in bui… #73937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bc-lee
Copy link
Contributor

@bc-lee bc-lee commented May 28, 2024

Cherry-pick of #73318 on release/6.0 branch.

…ld graph test

`unitest.assertEquals` is deprecated in Python 3.2 and finally removed in
Python 3.12 [1]. Due to this, this test files in recent Linux distros,
like Ubuntu 24.04 or Fedora 38+. This patch replaces the deprecated
function with `assertEqual`.

[1] https://docs.python.org/3/whatsnew/3.12.html

(cherry picked from commit c31f1f5)
@bc-lee bc-lee requested a review from a team as a code owner May 28, 2024 12:43
@bc-lee
Copy link
Contributor Author

bc-lee commented May 28, 2024

@shahmishal Please take a look. Thanks.

@JDevlieghere
Copy link
Contributor

@swift-ci test

@bc-lee
Copy link
Contributor Author

bc-lee commented Jun 30, 2024

@JDevlieghere Hi, can this patch be landed? Thanks!

@JDevlieghere JDevlieghere merged commit 3d76332 into swiftlang:release/6.0 Jul 1, 2024
5 checks passed
@bc-lee bc-lee deleted the feature/6.0-python-replace-deprecated-function-usage branch July 1, 2024 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants