Skip to content

[Concurrency] Reference dispatch_async_swift_job directly when the header is available. #73945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 29, 2024

Conversation

mikeash
Copy link
Contributor

@mikeash mikeash commented May 28, 2024

Only use dlsym when we don't have the header, since it's an unnecessary performance hit.

rdar://118465481

@mikeash
Copy link
Contributor Author

mikeash commented May 28, 2024

@swift-ci please test

…ader is available.

Only use dlsym when we don't have the header, since it's an unnecessary performance hit.

rdar://118465481
@mikeash mikeash force-pushed the dispatch-async-swift-job-no-dlsym branch from b7541d3 to c396f75 Compare May 28, 2024 21:35
@mikeash
Copy link
Contributor Author

mikeash commented May 28, 2024

Forgot the weak-link check.

@mikeash
Copy link
Contributor Author

mikeash commented May 28, 2024

@swift-ci please test

@mikeash mikeash requested a review from al45tair May 28, 2024 21:38
Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Lgtm

@mikeash
Copy link
Contributor Author

mikeash commented May 29, 2024

@swift-ci please test

@mikeash mikeash merged commit d0ed6f6 into swiftlang:main May 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants