[CSBindings] Optional object type variable should be connected to the optional #73960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… optional If both sides of an `OptionalObject` constraint are un-inferred, their binding sets need to correctly reflect adjacency - a type variable that represents optional would get "object" as an adjacency through its potential binding (the binding is - "object" wrapped in a single level of optional) and "object" type variable needs to get its parent optional type variable added to its adjacency list explicitly. Without this it would be possible to prematurely pick "object" before its parent optional type variable. Resolves: swiftlang#73207 Resolves: rdar://126960579
If the contextual type propagated into the optional chain mismatches with the inner type formed from its member references and that inner type is a result of some fix, let's consider that un-salvageable and avoid producing additional "ignore contextual type" fixes which only lead to subpar solutions.
|
@swift-ci please test |
hborla
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If both sides of an
OptionalObjectconstraint are un-inferred, theirbinding sets need to correctly reflect adjacency - a type variable
that represents optional would get "object" as an adjacency through
its potential binding (the binding is - "object" wrapped in a single
level of optional) and "object" type variable needs to get its parent
optional type variable added to its adjacency list explicitly.
Without this it would be possible to prematurely pick "object" before
its parent optional type variable.
Resolves: #73207
Resolves: rdar://126960579