[Generic signature builder] Substitute requirements instead of threading a PA around. #7398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing a PA around. This essentially undoes the implementation in 51da51d, which implicitly did a substitution of the Self type in a protocol's requirement signature by threading around the replacement PA. This is brittle because every part of the code needs to take and pass around the argument. By preemptively substituting, the whole requirement is in the right form from the time it enters `addRequirement`. The infrastructure here also allows simplifying some code.
huonw
changed the title
|
Yeah, this is definitely cleaner! |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This essentially undoes the implementation in 51da51d, which
implicitly did a substitution of the Self type in a protocol's
requirement signature by threading around the replacement PA. This is
brittle because every part of the code needs to take and pass around the
argument. By preemptively substituting, the whole requirement is in the
right form from the time it enters
addRequirement.The infrastructure here also allows simplifying some code, and some other clean-ups/bug fixes are included.