[6.0] [DebugInfo] [SILGen] Remove all invalid debug info from intermediates #73996
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Snowy1803
commented
May 30, 2024
Snowy1803
commented
- Explanation: The debug info on temporary allocations in SILGen were not removed if the function used parameter packs.
- Scope: Affects debug info at the SILGen level
- Original PR: [DebugInfo] [SILGen] Remove all invalid debug info from intermediates #73995
- Risk: Very low, only touches debug info when using parameter packs
- Testing: A new test has been added
- Issue: SIL verification failed when using tuples containing parameter packs #73030 (rdar://126556557)
- Reviewer: @adrian-prantl
The debug info on intermediates were not removed if the function used parameter packs Fixes swiftlang#73030 rdar://126556557 (cherry picked from commit a530534)
Snowy1803
changed the title
|
@swift-ci please test |
adrian-prantl
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.