-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Re-apply #70910 and fix 32-bit build with SWIFT_CONCURRENCY_ENABLE_PRIORITY_ESCALATION #73998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-apply #70910 and fix 32-bit build with SWIFT_CONCURRENCY_ENABLE_PRIORITY_ESCALATION #73998
Conversation
…age pattern" This reverts commit 2640ff6.
f621890
to
b5e039d
Compare
Thanks, I'll verify this on a 32bit box and report back! |
@swift-ci please test meanwhile letting this test run here as well so it's ready to go when we are |
@swift-ci please test |
Either way I'll make myself a reminder to implement the "TODO: make a flagset", we should do this anyway (rdar://128999427) |
Fix few issues. @ktoso, could you pls start new CI job? Implementation is quite hacky, I'm not super happy about it and open for better suggestions.
|
Previous seemed to have passed initial testing, I'll pick the last two commits as well and run another "complete" test run, those take multiple hours, but we'll know soon. Not sure 1) though, perhaps @rjmccall has insight on that. In the meantime I'll verify the latest commits here, thanks for looking into this. |
@swift-ci please smoke test |
I've confirmed 32bit issue is solved by this patch, thank you @nickolas-pohilets. |
Resolves rdar://114953765 |
I gave this another read and as mentioned above verified internally as well. Thanks for your effort over this long review period, thanks @nickolas-pohilets ! |
The definition of `DefautlActorImpl` changed in #73998. This change reflects those changes on to RemoteInspection's platform independent definition.
Reverts #73808
Moved
isDistributedRemoteActor
up, as suggested by @rjmccall.Now the layout looks like this: