[6.0] Implement pack element reference captures #74039
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hborla
approved these changes
May 31, 2024
…s in Type variable reference collector needs to be augmented to collect type variables associated with pack expansions that a closure references elements of, otherwise it would get disconnected from the context.
…nto scope If closure appears inside of a pack expansion, the elements that reference pack elements have to bring expansion's shape type in scope to make sure that the shapes match.
slavapestov
force-pushed
the
pack-element-expr-capture-6.0
branch
from
0f493b8 to
b6e8b39
Compare
Fixes swiftlang#68941. Fixes swiftlang#69282. Fixes swiftlang#72153. Fixes rdar://110711746. Fixes rdar://119212867. Fixes rdar://124202697.
slavapestov
force-pushed
the
pack-element-expr-capture-6.0
branch
from
b6e8b39 to
6809dc9
Compare
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6.0 cherry-pick of #74020 and @xedin's #73849.
Description: Builds upon #73541 to implement the missing cases involving closures appearing inside pack expansion expressions.
Scope of the issue: A very commonly reported bug.
Origination: This never worked.
Risk: Low. This re-purposes existing code for capturing OpaqueValueExprs, which arises up in property wrapper lowering. Now closures track captures of PackElementExprs in the same way.
Reviewed: @hborla @rjmccall
Radar: rdar://110711746, rdar://119212867, rdar://124202697.