[sending] Fix issues when suppressing SendingArgsAndResults found when adding sending to Swift Concurrency #74044
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble features to guard against parser errors. The code here was assuming that if we already emitted a compiler guard for non-Suppressable features, we could avoid doing it for suppressable features. The problem with this is that compiler() does more than just check for compiler versions... it also tells the compiler that parser errors in the if block should be ignored when if evaluates to false. rdar://129045783
…NominalTypes. These already worked... I am just adding the code coverage before I fix a different issue in the next commit. This will make it clearer what I am actually fixing in the next commit when one reads the tests.
…notes. rdar://129045783
… to inits. rdar://129045783
… out an increasing ID for all suppressed statements. I am using this to better test out suppression statements. I am finding that FileCheck runs into issues with some of the '#if' lines I am trying to match. I am able to use this option with my asserts only test to uniquely identify a '#if ...' statement and thus have the pattern matching work. I needed this to get the test in the next commit to pass testing.
gottesmm
requested review from
ktoso,
hborla,
slavapestov,
xedin and
tshortli
as code owners
gottesmm
force-pushed
the
pr-e9ee61c33e84d5df61764b06277a75cdfe3b58d0
branch
from
79b334e to
bfb5096
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on adding sending to some APIs in the stdlib, I noticed these issues were showing up in the swift interface file produces for Concurrency.
This PR fixes all of the issues I found:
rdar://129045783