Skip to content

Revert "[Sema] Warn about 'Any' to 'any Sendable' override" #74045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2024

Conversation

xedin
Copy link
Contributor

@xedin xedin commented May 31, 2024

Reverts #73158

I am not sure why this was merged since there is another PR with further discussion about approaches to fix this - #73543, specifically #73543 (comment). Comments have been marked resolved although they are not even when it comes to test coverage.

@xedin
Copy link
Contributor Author

xedin commented May 31, 2024

@swift-ci please smoke test

@xedin
Copy link
Contributor Author

xedin commented May 31, 2024

@swift-ci please clean test macOS platform

Copy link
Contributor

@ktoso ktoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh boy, it seems the comments were only dismissed but not resolved huh... LGTM

@xedin
Copy link
Contributor Author

xedin commented May 31, 2024

@swift-ci please test macOS platform

@xedin
Copy link
Contributor Author

xedin commented May 31, 2024

@swift-ci please clean test macOS platform

@xedin
Copy link
Contributor Author

xedin commented May 31, 2024

@swift-ci please test macOS platform

1 similar comment
@glessard
Copy link
Contributor

@swift-ci please test macOS platform

@xedin xedin merged commit 979cd16 into main Jun 1, 2024
4 checks passed
@xedin xedin deleted the revert-73158-any-to-any-sendable-override branch June 1, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants