[6.0] SILGen: Diagnose unsupported shared case blocks for noncopyable switch subjects. #74054
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h subjects. This isn't fully implemented yet so it would crash eventually, so instead of letting the compiler crash put up a proper diagnostic indicating this isn't yet implemented. rdar://129034189
|
@swift-ci Please test |
|
@swift-ci Please clean test macOS |
1 similar comment
|
@swift-ci Please clean test macOS |
tbkka
approved these changes
Jun 3, 2024
kavon
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Diagnoses currently-unimplemented noncopyable switches involving
fallthroughor multiple patterns in a single case label.Scope: Replaces a "not implemented" assertion failure with a proper diagnostic.
Issue: rdar://129034189
Original PR: #74041
Risk: Low. Replaces a "not implemented" assertion failure with a proper diagnostic.
Testing: Swift CI
Reviewer: @kavon