[6.0] Handle startAsyncLetWithLocalBuffer in exclusivity diagnostics. #74059
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes rdar://128981120 (Crash when inout arg captured through some closures? (llvm::all_of(apply->getUses(), hasExpectedUsesOfNoEscapePartialApply) && "noescape partial_apply has unexpected use!")) (cherry picked from commit 1be703c)
|
@swift-ci test |
|
@tbkka needs approval |
tbkka
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes rdar://128981120 (Crash when inout arg captured through some closures? (llvm::all_of(apply->getUses(), hasExpectedUsesOfNoEscapePartialApply) && "noescape partial_apply has unexpected use!"))
(cherry picked from commit 1be703c)
--- CCC ---
Explanation: Fix a compiler assert in exclusivity diagnostics.
Scope: The assert is in verification that tests completeness of the diagnostic. It only affects asserts builds of the compiler.
Radar/SR Issue: rdar://128981120 (Crash when inout arg captured through some closures? (llvm::all_of(apply->getUses(), hasExpectedUsesOfNoEscapePartialApply) && "noescape partial_apply has unexpected use!"))
main PR: #74029
Risk: None.
Testing: Unit test added.
Reviewer: @nate-chandler