[Coverage] Avoid recording regions from macro expansions #74067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hamishknight
commented
May 31, 2024
ahoppen
approved these changes
Jun 1, 2024
| // We want to walk into initializers for bindings, and the expansions of | ||
| // MacroExpansionDecls, which will be nested within MacroExpansionExprs in | ||
| // local contexts. | ||
| return isa<PatternBindingDecl>(D) || isa<MacroExpansionDecl>(D); |
There was a problem hiding this comment.
How do we report code coverage for the expansions of a macro? Or I don’t fully understand why we need to walk into MacroExpansionDecl.
There was a problem hiding this comment.
We don't, the only reason we need to walk into the expansion is to get accurate counter information for the following code, e.g for #id(try throwingFn()), we need to account for the fact that code after the macro may not run if an error was thrown
hamishknight
force-pushed
the
macroscope
branch
3 times, most recently
from
780aab4 to
77fca82
Compare
Saves having to pass it as a parameter to `emitSourceRegions`.
Ignore any regions recorded while inside a macro expansion, but account for any control flow that may have happened such that the exit count is correctly adjusted. This allows e.g throwing function calls to behave correctly within the expansion. rdar://129081384
These replace the body of the function, and as such shouldn't be profiled.
Make sure we walk macro expansion decls to handle cases where e.g a binding introduces control flow. This should be a pretty uncommon case since bindings introduced by macros aren't actually usable when expanded in local contexts, but handle it all the same.
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore any regions recorded while inside a macro expansion, but account for any control flow that may have happened such that the exit count is correctly adjusted. This allows e.g throwing function calls to behave correctly within the expansion.
Additionally, make sure we avoid profiling functions with function body macros.
rdar://129081384