Skip to content

[cxx-interop][SwiftCompilerSources] Remove a workaround #74094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

egorzhdan
Copy link
Contributor

The definition of ~BasicCalleeAnalysis can now be inlined.

rdar://127152872 / resolves #64502

The definition of `~BasicCalleeAnalysis` can now be inlined.

rdar://127152872 / resolves #64502
@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Jun 3, 2024
@egorzhdan egorzhdan requested a review from eeckstein June 3, 2024 13:05
@egorzhdan
Copy link
Contributor Author

@swift-ci please test

@eeckstein
Copy link
Contributor

@egorzhdan Did you try with a debug build (locally on your machine)?

@egorzhdan
Copy link
Contributor Author

Yes, I just tried a debug hosttools build locally, it succeeded.

Copy link
Contributor

@eeckstein eeckstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@egorzhdan
Copy link
Contributor Author

@swift-ci please test

@egorzhdan egorzhdan merged commit b3c13e4 into main Sep 3, 2024
5 checks passed
@egorzhdan egorzhdan deleted the egorzhdan/scs-inline-dtor branch September 3, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Undefined symbols when using BasicCalleeAnalysis in SwiftCompilerSources
2 participants