Skip to content

Revert "[stdlib] Mark some UnsafePointer APIs as transparent" #74098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2024
Merged

Revert "[stdlib] Mark some UnsafePointer APIs as transparent" #74098

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 6 additions & 7 deletions stdlib/public/core/UnsafePointer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,8 +262,8 @@ extension UnsafePointer where Pointee: ~Copyable {
/// This pointer must be a pointer to the start of a previously allocated
/// memory block. The memory must not be initialized or `Pointee` must be a
/// trivial type.
@inlinable
@_preInverseGenerics
@_transparent
public func deallocate() {
// Passing zero alignment to the runtime forces "aligned
// deallocation". Since allocation via `UnsafeMutable[Raw][Buffer]Pointer`
Expand Down Expand Up @@ -777,8 +777,8 @@ extension UnsafeMutablePointer where Pointee: ~Copyable {
///
/// - Parameter count: The amount of memory to allocate, counted in instances
/// of `Pointee`.
@inlinable
@_preInverseGenerics
@_transparent
public static func allocate(
capacity count: Int
) -> UnsafeMutablePointer<Pointee> {
Expand Down Expand Up @@ -810,8 +810,8 @@ extension UnsafeMutablePointer where Pointee: ~Copyable {
/// This pointer must be a pointer to the start of a previously allocated
/// memory block. The memory must not be initialized or `Pointee` must be a
/// trivial type.
@inlinable
@_preInverseGenerics
@_transparent
public func deallocate() {
// Passing zero alignment to the runtime forces "aligned
// deallocation". Since allocation via `UnsafeMutable[Raw][Buffer]Pointer`
Expand Down Expand Up @@ -898,7 +898,6 @@ extension UnsafeMutablePointer where Pointee: ~Copyable {
/// - Parameters:
/// - value: The instance to initialize this pointer's pointee to.
@_alwaysEmitIntoClient
@_transparent
public func initialize(to value: consuming Pointee) {
Builtin.initialize(value, self._rawValue)
}
Expand Down Expand Up @@ -929,8 +928,8 @@ extension UnsafeMutablePointer where Pointee: ~Copyable {
/// `move()`, the memory is uninitialized.
///
/// - Returns: The instance referenced by this pointer.
@inlinable
@_preInverseGenerics
@_transparent
public func move() -> Pointee {
return Builtin.take(_rawValue)
}
Expand Down Expand Up @@ -1163,9 +1162,9 @@ extension UnsafeMutablePointer where Pointee: ~Copyable {
/// not be negative.
/// - Returns: A raw pointer to the same address as this pointer. The memory
/// referenced by the returned raw pointer is still bound to `Pointee`.
@discardableResult
@inlinable
@_preInverseGenerics
@_transparent
@discardableResult
public func deinitialize(count: Int) -> UnsafeMutableRawPointer {
_debugPrecondition(count >= 0, "UnsafeMutablePointer.deinitialize with negative count")
// Note: When count is statically known to be 1 the compiler will optimize
Expand Down
3 changes: 3 additions & 0 deletions test/SILOptimizer/stdlib/Cell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ public struct Cell<T: ~Copyable>: ~Copyable {
// CHECK: bb0({{%.*}} : $*Cell<T>, [[VALUE:%.*]] : $*T, {{%.*}} : $@thin Cell<T>.Type):
// CHECK: {{%.*}} = builtin "zeroInitializer"<Cell<T>>([[SELF:%.*]] : $*Cell<T>) : $()
// CHECK-NEXT: [[RAW_LAYOUT_ADDR:%.*]] = builtin "addressOfRawLayout"<Cell<T>>([[SELF]] : $*Cell<T>) : $Builtin.RawPointer
// CHECK-NEXT: [[POINTER:%.*]] = struct $UnsafeMutablePointer<T> ([[RAW_LAYOUT_ADDR]] : $Builtin.RawPointer)
// Calling 'UnsafeMutablePointer<T>.initialize(to:)'
// CHECK: {{%.*}} = apply {{%.*}}<T>([[VALUE]], [[POINTER]])
// CHECK-LABEL: } // end sil function '$s4CellAAVAARi_zrlEyAByxGxcfC'
@_transparent
public init(_ value: consuming T) {
Expand Down