Skip to content

[6.0] Sema: Fix request cycle with isolation inference #74102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2024
Merged

[6.0] Sema: Fix request cycle with isolation inference #74102

merged 1 commit into from
Jun 4, 2024

Conversation

slavapestov
Copy link
Contributor

@slavapestov slavapestov commented Jun 3, 2024 •
edited
Loading

6.0 cherry-pick of #74100.

  • Description: Fixes a request cycle with global actor inference. We were doing too much work computing isolation of nested types, by looking up conformances on the parent type unnecessarily. Nested types cannot inherit @MainActor etc from the same attribute on an associated type, so skipping this has no semantic effect.
  • Origination: Existing issue exposed by dd1a85c.
  • Radar: rdar://129024926.
  • Risk: Very low.
  • Reviewed by: @hborla

@slavapestov slavapestov requested a review from a team as a code owner June 3, 2024 18:43
@slavapestov
Copy link
Contributor Author

@swift-ci Please test

@slavapestov slavapestov merged commit 79cf063 into swiftlang:release/6.0 Jun 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hborla hborla hborla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slavapestov @hborla