[6.0][ScanDependency] Handle -Xcc options that affects module generation
#74106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the `-Xcc` options to the scanner are correctly considered when creating ClangImporterCC1 arguments for constructed swift interface compilation job. Under directcc1 mode, `-Xcc` options should be used to constructed sub-invocation but should not be added to GenericArgs for constructing interface compilation jobs. rdar://128873665 (cherry picked from commit 42732c0)
|
@swift-ci please test |
nkcsgexi
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fix an issue when swift caching or direct cc1 scanning mode is enabled for explicit module build, some
-Xccflags that are affecting module generations are not passed to swift interface compilation job.Scope: Fix module configuration mismatch when swift caching is on and certain
-Xccflags are passed to driver.Issue: rdar://128873665
Original PR: #74012
Reviewer: @artemcm
Risk: Low. Only swift caching uses the new scanner mode.
Test: UnitTests.