Skip to content

[6.0] [IRGen] Add option for raw layout to move as its like type #74115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 13, 2024
Merged

[6.0] [IRGen] Add option for raw layout to move as its like type #74115

merged 4 commits into from
Jun 13, 2024

Conversation

Azoy
Copy link
Contributor

@Azoy Azoy commented Jun 4, 2024

This is a cherry pick of #73955, #74053, and #74095

  • Explanation: In order for types like Mutex to store arbitrary types, raw layout needs to support moving like the type it's like. Add an option movesAsLike to the attribute to let types opt into this behavior and call into their underlying type to figure out how to move themselves.
  • Scope: Types using @_rawLayout which should be only the stdlib.
  • Main Branch PR: [IRGen] Add option for raw layout to move as its like type #73955
  • Risk: Low
  • Reviewed By: @jckarter
  • Testing: New tests added to the test suite.

Azoy added 3 commits June 4, 2024 09:00
@Azoy
Merge pull request swiftlang#73955 from Azoy/show-me-those-moves
9bacb9f 
[IRGen] Add option for raw layout to move as its like type
@Azoy
Merge pull request swiftlang#74053 from Azoy/raw_layout_test_fix
9137b01 
[test] Update raw_layout.swift
@Azoy
Merge pull request swiftlang#74095 from Azoy/raw_layout_test_fix_again
1bf19c2 
[test] Update IRGen/raw_layout.swift test failure
@Azoy Azoy requested a review from stephentyrone June 4, 2024 16:04
@Azoy Azoy requested a review from a team as a code owner June 4, 2024 16:04
@Azoy
Copy link
Contributor Author

Azoy commented Jun 4, 2024

@swift-ci please test

@Azoy
Copy link
Contributor Author

Azoy commented Jun 4, 2024

@swift-ci please test

@Azoy Azoy merged commit 332d23e into swiftlang:release/6.0 Jun 13, 2024
5 checks passed
@Azoy Azoy deleted the 60-show-me-those-moves branch June 13, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephentyrone stephentyrone stephentyrone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Azoy @stephentyrone