Sema: Report public conformances to non-publicly imported protocols #74142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
xymus
commented
Jun 5, 2024
| @@ -3645,7 +3645,8 @@ ERROR(decl_from_hidden_module,none, | |||
| "in an extension with public or '@usableFromInline' members|" | |||
| "in an extension with conditional conformances|" | |||
| "in an extension with public, package, or '@usableFromInline' members|" | |||
| "in an extension with conditional conformances}1; " | |||
| "in an extension with conditional conformances|" | |||
| "in an exported conformance}1; " | |||
There was a problem hiding this comment.
This diagnostic text is not ideal but I'd rather keep it simple until this is merged back to 6.0 to avoid complications.
|
Thank you! |
|
@swift-ci Please smoke test |
tshortli
approved these changes
Jun 11, 2024
lib/Sema/ResilienceDiagnostics.cpp
Outdated
| reason != ExportabilityReason::ExtensionWithPackageMembers && | ||
| reason != ExportabilityReason::ExtensionWithConditionalConformances && | ||
| reason != ExportabilityReason::ExtensionWithPackageConditionalConformances) | ||
| bool reportHere = |
There was a problem hiding this comment.
Would it maybe make sense to use a switch to cover ExportabilityReason? It seems like it could clean this up a bit.
There was a problem hiding this comment.
Good idea. I was trying to find ways to simplify this logic and didn't consider this alternative. It's updated.
|
@swift-ci Please smoke test |
tshortli
approved these changes
Jun 11, 2024
Exportability checking for non-public imports relies on classic access-level checks for some of the work. However while conforming to a local internal protocol from a public type is allow we should disallow it for imported types, even when imported as internal. Track exportability issues on conformances to protocols separately from the general category. Use that information to improve the diagnostics and report these issues for access-level on imports. rdar://128420980
xymus
force-pushed
the
access-level-conformances
branch
from
6ae12d7 to
275c534
Compare
xymus
force-pushed
the
access-level-conformances
branch
from
275c534 to
e5bc35b
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exportability checking for non-public imports relies on classic access-level checks for some of the work. However while conforming to a local internal protocol from a public type is allow we should disallow it for imported types, even when imported as internal.
Track exportability issues on conformances to protocols separately from the general category. Use that information to improve the diagnostics and report these issues for access-level on imports.
rdar://128420980