Turn mishandled reinitialize-in-defer-after-consume cases into errors.
#74154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rors. The handling of multi-basic-block control flow in `defer` blocks looks like it was left incomplete and completely untested; I fixed a few obvious problems but it still completely lacks any analysis of conditional reinitializations. For now, change it to treat attempted reinitializations as uses-after-consumes so we raise reliable errors now instead of emitting code that causes memory corruption at runtime. Fixes rdar://129303198.
jckarter
requested review from
kavon,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The handling of multi-basic-block control flow in
deferblocks looks like it was left incomplete and completely untested; I fixed a few obvious problems but it still completely lacks any analysis of conditional reinitializations. For now, change it to treat attempted reinitializations as uses-after-consumes so we raise reliable errors now instead of emitting code that causes memory corruption at runtime. Fixes rdar://129303198.