[Synchronization] Fix wasm atomic intrinsic declarations #74171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, isel will not be able to select the desired atomic instructions.
…ebAssembly Use of atomics instructions requires the support of threads proposal and it's not widely supported yet. So we should enable actual atomic operations only when targeting wasm32-uknown-wasip1-threads.
|
@swift-ci test WebAssembly |
|
@swift-ci smoke test |
Azoy
reviewed
Jun 6, 2024
|
|
||
| extension Atomic where Value == _MutexHandle.State { | ||
| internal borrowing func _wait(expected: _MutexHandle.State) { | ||
| _swift_stdlib_wait( | ||
| #if _runtime(_multithreaded) |
There was a problem hiding this comment.
I think we should generally make Mutex unavailable when the runtime isn't multithreaded
There was a problem hiding this comment.
although I guess it doesn't really matter because Mutex can always acquire in the single threaded context and needing to call wait or notify should ever occur so this is probably fine.
There was a problem hiding this comment.
Ah, it might be better to have a separate noop implementations for single threaded targets instead of just skipping wait/notify operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, isel will not be able to select the desired atomic instructions.
Use of atomics instructions requires the explicit support of threads proposal and it's not widely supported yet. So we should enable actual atomic operations only when targeting wasm32-uknown-wasip1-threads.
Those changes repair the current test failure:
https://ci.swift.org/job/swift-PR-Linux-crosscompile-wasm/106/console