Change macro expansion mangling to avoid request cycles #74201
Conversation
lib/AST/Expr.cpp
Outdated
| dump(llvm::errs()); | ||
| abort(); |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
slavapestov
force-pushed
the
macro-expansion-mangling
branch
from
47ff956 to
f11b956
Compare
slavapestov
requested review from
ahoppen,
bnbarham,
hamishknight,
rintaro,
hborla and
xedin
as code owners
slavapestov
force-pushed
the
macro-expansion-mangling
branch
from
f11b956 to
f26b625
Compare
|
@swift-ci Please smoke test |
| #anonymousTypes(public: false) { "goodbye" } | ||
|
|
||
| // FIXME: This test |
There was a problem hiding this comment.
Drive-by comment: Is this a leftover comment?
There was a problem hiding this comment.
Nope, the test is broken or there's a bug; I noticed that changing 'public' to true has no effect on the SIL output, which I think is wrong.
There was a problem hiding this comment.
Ah, I see what you by the FIXME now with your comment. Do you think it would be valuable to include more information about what in the test needs fixing (essentially putting your GitHub comment in the source code)? I’m just thinking that somebody reading this FIXME in a year or two might have a hard time understanding what it was referring to.
Fixes rdar://127078338.
slavapestov
force-pushed
the
macro-expansion-mangling
branch
from
f26b625 to
9793f77
Compare
|
swiftlang/llvm-project#8898 |
Fixes rdar://127078338.