Skip to content

[cxx-interop] Only run tests for reference types against a recent Swift runtime #74261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

egorzhdan
Copy link
Contributor

Having a Swift array of C++ reference types without crashing at runtime only became possible recently (#73615). When building against an older runtime, one would still see runtime crashes. This is expected because part of the fix is in the Swift runtime.

This makes sure we don't try to run tests for C++ reference types with an older Swift runtime.

rdar://128681137

…ft runtime

Having a Swift array of C++ reference types without crashing at runtime only became possible recently (#73615). When building against an older runtime, one would still see runtime crashes. This is expected because part of the fix is in the Swift runtime.

This makes sure we don't try to run tests for C++ reference types with an older Swift runtime.

rdar://128681137
@egorzhdan egorzhdan added the c++ interop Feature: Interoperability with C++ label Jun 10, 2024
@egorzhdan egorzhdan requested review from Xazax-hun and ahatanaka June 10, 2024 16:50
@egorzhdan egorzhdan requested review from zoecarver and hyp as code owners June 10, 2024 16:50
@egorzhdan
Copy link
Contributor Author

@swift-ci please test

@egorzhdan egorzhdan merged commit 876c056 into main Jun 11, 2024
5 checks passed
@egorzhdan egorzhdan deleted the egorzhdan/old-runtime-test branch June 11, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant