Skip to content

6.0: [MoveOnly] Call mutating methods on existentials. #74265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nate-chandler
Copy link
Contributor

@nate-chandler nate-chandler commented Jun 10, 2024

Explanation: Fix a diagnostic-on-valid in the move-checker.

Previously, calling a mutating method on a non-copyable existential failed with error: usage of a noncopyable type that compiler can't verify. Here, this is fixed.
Scope: Affects non-copyable code.
Issue: rdar://128900124
Original PR: #74198
Risk: Low. The fix is small and targeted.
Testing: Added regression test.
Reviewer: Andrew Trick ( @atrick )

It's a pass-through for FSPL's purposes.

rdar://128900124
@nate-chandler
Copy link
Contributor Author

@swift-ci please test

@nate-chandler nate-chandler enabled auto-merge June 10, 2024 19:11
@nate-chandler nate-chandler merged commit df0f784 into swiftlang:release/6.0 Jun 10, 2024
5 checks passed
@nate-chandler nate-chandler deleted the cherrypick/release/6.0/rdar128900124 branch June 10, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants