[6.0] Don't pass foundation build path to swift-driver/swift-package-manager #74272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
parkera
approved these changes
Jun 11, 2024
bnbarham
approved these changes
Jun 11, 2024
ktoso
pushed a commit
to ktoso/swift
that referenced
this pull request
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #74217
Explanation: Removes the
--foundation-build-dirparameter given to the swift driver and swiftpm builds allowing them to depend on the modules in the just-built toolchain insteadScope: Affects the build of the Yams project within the swift driver and swiftpm builds
Original PR: #74217
Risk: Small - this is only used by the Yams build (which depends on Foundation) and in both of these cases, Foundation is already installed into the just-built toolchain
Testing: PR testing via swift-ci, toolchain build via swift-ci, and local toolchain builds
Reviewer: @etcwilde @bnbarham @iCharlesHu