[6.0][Sema] Diagnose deprecated default implementations in the witness checker. #74276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
hborla
commented
Jun 11, 2024
hborla
commented
- Explanation: If a protocol provides a deprecated default implementation for a requirement that is not deprecated, the compiler should emit a warning so the programmer can provide an explicit implementation of the requirement. This is helpful for staging in new protocol requirements that should be implemented in conforming types.
- Scope: Only impacts protocols that provide deprecated default implementations for non-deprecated requirements, and conforming types that use the default implementation.
- Issue: rdar://123403268
- Risk: Low; this change only adds deprecation warnings.
- Testing: Added a new test.
- Reviewer: @slavapestov @tshortli @AnthonyLatsis
- Main branch PR: [Sema] Diagnose deprecated default implementations in the witness checker. #74244
…cker. If a protocol provides a deprecated default implementation for a requirement that is not deprecated, the compiler should emit a warning so the programmer can provide an explicit implementation of the requirement. This is helpful for staging in new protocol requirements that should be implemented in conforming types. (cherry picked from commit 005b45c)
(cherry picked from commit 5da7ac6)
|
@swift-ci please test |
nkcsgexi
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.