Skip to content

[6.0][region-isolation] Dont crash when processing global actor isolated init accessors. #74326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

gottesmm
Copy link
Contributor

@gottesmm gottesmm commented Jun 12, 2024

Explanation: This PR makes sure that we do not crash when we process global actor isolated init accessors. The crash is a result of memory corruption due to misinterpreting a union + enum (a c++ version of an enum + associated values).

  • rdar://129256560

Original PRs:

Risk: Low. This only impacts global actor isolated init accessors that we would crash on without this anyways.
Testing: Added tests to the test suite.
Reviewer: N/A

…nit accessors.

This just means that I stopped treating it like an actor instance isolated
thing. This was fun to track down since ActorIsolation has a union in it that
was being misinterpreted, leading to memory corruption... my favorite! = ).

rdar://129256560
(cherry picked from commit f035590)
@gottesmm gottesmm requested a review from a team as a code owner June 12, 2024 08:05
@gottesmm
Copy link
Contributor Author

@swift-ci test

@gottesmm gottesmm enabled auto-merge June 12, 2024 08:06
@gottesmm gottesmm changed the title [region-isolation] Dont crash when processing global actor isolated init accessors. [6.0][region-isolation] Dont crash when processing global actor isolated init accessors. Jun 12, 2024
@gottesmm
Copy link
Contributor Author

Original: #74321

@gottesmm gottesmm merged commit f6be435 into swiftlang:release/6.0 Jun 12, 2024
5 checks passed
@gottesmm gottesmm deleted the release/6.0-129256560 branch June 12, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants