AST: fix isWrittenWithConstraints
#74372
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Surprisingly, there are some situations where an extension can end up with _fewer_ constraints than the extended type. That was baked-in as an assertion in this new-ish method. I haven't figured out why that can happen in the reproducer only when using `-interpret` mode. It didn't trigger the assertion for me when compiling normally. The fix is simple: check all the requirements, rather than using a short-cut. resolves rdar://125659789 / swiftlang#72719
|
@swift-ci test |
|
@swift-ci test macOS |
kavon
added a commit
to kavon/swift
that referenced
this pull request
Jun 13, 2024
This is a follow-up to clean-up swiftlang#74372
kavon
added a commit
to kavon/swift
that referenced
this pull request
Jun 13, 2024
This is a follow-up to clean-up swiftlang#74372
kavon
added a commit
to kavon/swift
that referenced
this pull request
Jun 13, 2024
This is a follow-up to clean-up swiftlang#74372 (cherry picked from commit e4ed330)
meg-gupta
pushed a commit
to meg-gupta/swift
that referenced
this pull request
Jun 20, 2024
This is a follow-up to clean-up swiftlang#74372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprisingly, there are some situations where an extension can end up with fewer constraints than the extended type. The assumption that it's always more or the same number of requirements was baked-in as an assertion in this new-ish method.
I haven't figured out why that can happen in the reproducer only when using
-interpretmode. It didn't trigger the assertion for me when compiling normally.The fix is simple: check all the requirements, rather than using a short-cut.
resolves rdar://125659789 / #72719