[6.0] MoveOnlyAddressChecker: Turn assertion into early exit. #74376
+31
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This condition can occur in practice if, while doing the walk back to find the liveness reason for a consume-without-reinitialization of an `inout` binding through conditional control flow, we visit a block that reinitializes the binding before any branch that leaves the binding uninitialized. Fixes rdar://123604613.
jckarter
changed the title
|
@swift-ci Please test |
tbkka
approved these changes
Jun 13, 2024
gottesmm
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes a crash-on-invalid when an
inoutparameter is consumed but is only initialized on some but not all subsequent conditional paths that appear in a certain order.Scope: Bug fix.
Issue: rdar://123604613
Original PR: #74374
Risk: Low. Removes an assertion and replaces it with control flow skipping the case.
Testing: Swift CI, test case from bug report
Reviewer: @gottesmm