Provide property source locations for @_documentation.
#74404
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was breaking macro expansion in the weirdest way. Fixes rdar://127206128
DougGregor
requested review from
ahoppen,
bnbarham,
CodaFi,
hamishknight and
rintaro
as code owners
|
@swift-ci please smoke test |
|
I'm genuinely curious how this caused the breakage. |
grynspan
reviewed
Jun 13, 2024
| @@ -220,3 +220,8 @@ struct SomeType { | |||
| macro multipleFreestandingRoles<T>(_: T) -> Void = #externalMacro(module: "A", type: "B") | |||
| // expected-warning@-1{{external macro implementation type}} | |||
| // expected-error@-2{{macro can only have a single freestanding role}} | |||
|
|
|||
There was a problem hiding this comment.
May I suggest having an additional test with the attributes in the opposite order too?
There's an optimization that grabs the full source range of the macro, including its attributes, and hands that over to the new Swift parser to perform checking on the definition. The (old, C++) Swift parser got the starting source location for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was breaking macro expansion in the weirdest way. Fixes rdar://127206128