[ASTDumper] Avoid parsing decl members #74409
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The body range may be valid; change `getStartLoc` to fall back to the body's start loc to match `getEndLoc`.
Previously we would call `getMembers`, which could kick delayed member parsing. Instead, propagate a `parseIfNeeded` flag through the ASTDumper logic, and use it to determine whether to parse a SourceFile, type/extension body, or function body. This is needed for things like `-dump-parse` which expects to dump the entire AST tree.
hamishknight
force-pushed
the
no-member-parsing-in-dump
branch
from
f4e25cf to
a8c7261
Compare
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we would call
getMembers, which could kick delayed member parsing. Instead, propagate aparseIfNeededflag through the ASTDumper logic, and use it to determine whether to parse a SourceFile, type/extension body, or function body. This is needed for things like-dump-parsewhich expects to dump the entire AST tree.