[6.0][AST] @preconcurrency conformance applies to implied conformances as well
#74429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s well
A `@preconcurrency` conformance to an inherited protocol should imply
`@preconcurrency` on its parents as well. For example:
```swift
protocol Parent {
func a()
}
protocol Child: Parent {
func b()
}
@mainactor
class Test: @preconcurrency Child {
func a() {
}
func b() {
}
}
```
`Test` conformance to `Parent` implied by its conformance to `Child`
should carry `@preconcurrency` and inject dynamic actor isolation checks
to witness of `a()`.
Resolves: swiftlang#74294
Resolves: rdar://129599097
(cherry picked from commit 414295d)
|
@swift-ci please test |
hborla
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #74315
Explanation:
A
@preconcurrencyconformance to an inherited protocol should imply@preconcurrencyon its parents as well. For example:Testconformance toParentimplied by its conformance toChildshould carry@preconcurrencyand inject dynamic actor isolation checks to witness ofa().Main Branch PR: [AST]
@preconcurrencyconformance applies to implied conformances a… #74315Resolves: rdar://129599097
Risk: Low
Reviewed By: @hborla
Testing: Existing test-cases were modified and new tests were added.
Resolves: #74294
(cherry picked from commit 414295d)