[Sema] Fix hole where missing_nullary_call wasn't diagnosed in ternary condition. #74464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test. |
|
@swift-ci Please smoke test. |
hamishknight
approved these changes
Jun 17, 2024
xedin
approved these changes
Jun 17, 2024
|
If you'd be interested in trying a more challenging diagnostic fix - #67791 (comment). I think I reduced this at some point to a ternary as well but I cannot find it. |
|
@xedin I'll give it a shot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a check for
function produces expected type 'Bool'; did you mean to call it with '()'?when in the position of a condition for a ternary expression. Because of the wayContextualFailures are diagnosed, this particular diagnostic couldn't be hit before.Resolves #46902.