[embedded] Skip EagerSpecializer on embedded Swift #74480
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kubamracek
requested review from
MaxDesiatov,
phausler,
rauhul,
zoecarver and
eeckstein
|
@swift-ci please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EagerSpecializer SIL pass processes
@_specialize-annotated functions and creates a "type check" in them that compares metadata. This is (1) incompatible with Embedded Swift, because metadata are not available there, and (2) unnecessary in Embedded Swift because all functions are fully specialized already. Let's disable EagerSpecializer when compiling in Embedded Swift mode.This fixes a compilation error when using anything that's
@_specialize-annotated. Before this fix, using e.g. theSubstring.init<S: Sequence>(_ elements: S) where S.Element == Characterfunction from the stdlib (which has the annotation) results in:See the attached testcase.