[ClangImporter] Always add AnyObject constraint to generic parameters
#74492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
requested review from
zoecarver,
hyp,
egorzhdan,
beccadax and
ian-twilightcoder
as code owners
xedin
commented
Jun 17, 2024
test/ClangImporter/objc_method_with_sendable_generic_requirement.swift
Outdated
Show resolved
Hide resolved
xedin
changed the title
AnyObject constraint on generic parametersAnyObject constraint to generic parameters
`: AnyObject` was added only if there were no other constraints because all of them would imply it before, with introduction of `Sendable` this is no longer the case. Let's add `AnyObject` constraint unconditionally and let generic signature builder deal with the redundancy. Resolves: rdar://127520993
jckarter
approved these changes
Jun 17, 2024
|
@swift-ci please test |
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
: AnyObjectwas added only if there were no other constraints because all of them would imply it before, with introduction ofSendablethis is no longer the case. Let's addAnyObjectconstraint unconditionally and let generic signature builder deal with the redundancy.Resolves: rdar://127520993