[6.0] Include error type when considering whether a SILFunctionType needs its substitutions. #74527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts substitutions. Fixes rdar://128205122.
tbkka
approved these changes
Jun 20, 2024
|
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: Fixes a compiler crash when a closure literal with a concrete error type is used in the context of a function that's generic over the closure's error parameter.
Scope: Bug fix.
Issue: rdar://128205122
Original PR: #74525
Risk: Low. A small bug fix that should only affect new code using typed throws.
Testing: Swift CI, test case from bug report
Reviewer: @slavapestov, @rjmccall