[6.0][region-isolation] Check if we have a self param before attempting to get the self type. #74530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… get the self type. Otherwise in asserts builds we get an assert and in no-asserts we get a crash. rdar://129975097 (cherry picked from commit d032bc0)
|
@swift-ci test |
hborla
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: This PR fixes a small bug where we were attempting to call some "self" oriented APIs without checking if we actually had a self parameter.
Radars:
Original PRs:
Risk: Low. This is a very small targeted fix that can be seen to be correct on the tin.
Testing: Added a test.
Reviewer: N/A