[Features] Promote IsolatedAny and its alias to a language feature.
#74543
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proposal is accepted and implemented for Swift 6.0.
hborla
requested review from
AnthonyLatsis,
slavapestov,
xedin,
ahoppen,
bnbarham,
CodaFi,
DougGregor,
hamishknight,
rintaro and
ktoso
as code owners
hborla
requested review from
rjmccall and
tshortli
and removed request for
xedin,
slavapestov,
ktoso,
rintaro,
DougGregor,
bnbarham,
CodaFi,
ahoppen,
hamishknight and
AnthonyLatsis
ktoso
approved these changes
Jun 19, 2024
|
@swift-ci please smoke test |
tshortli
added a commit
to tshortli/swift
that referenced
this pull request
Jul 3, 2024
Supported older compilers don't enable this feature by default, so it can't be omitted from the `_Concurrency` module's flags (regression from swiftlang#74543). Additionally, remove `@_allowFeatureSuppression(IsolatedAny)` from all declarations. We no longer need to support compilers that don't have the `IsolatedAny` feature, so the suppression is superfluous and the alternative branches didn't actually build anyways. _Additionally_, the suppressible feature logic could not handle suppressing `IsolatedAny` simultaneously with `SendingArgsAndResults`, resulting in a broken interface because `sending` was used outside `#if $SendingArgsAndResults` guards.
tshortli
added a commit
to ktoso/swift
that referenced
this pull request
Jul 3, 2024
Supported older compilers don't enable this feature by default, so it can't be omitted from the `_Concurrency` module's flags (regression from swiftlang#74543). Additionally, remove `@_allowFeatureSuppression(IsolatedAny)` from all declarations. We no longer need to support compilers that don't have the `IsolatedAny` feature, so the suppression is superfluous and the alternative branches didn't actually build anyways. _Additionally_, the suppressible feature logic could not handle suppressing `IsolatedAny` simultaneously with `SendingArgsAndResults`, resulting in a broken interface because `sending` was used outside `#if $SendingArgsAndResults` guards.
tshortli
added a commit
to ktoso/swift
that referenced
this pull request
Jul 3, 2024
Supported older compilers don't enable this feature by default, so it can't be omitted from the `_Concurrency` module's flags (regression from swiftlang#74543). Additionally, remove `@_allowFeatureSuppression(IsolatedAny)` from all declarations. We no longer need to support compilers that don't have the `IsolatedAny` feature, so the suppression is superfluous and the alternative branches didn't actually build anyways. _Additionally_, the suppressible feature logic could not handle suppressing `IsolatedAny` simultaneously with `SendingArgsAndResults`, resulting in a broken interface because `sending` was used outside `#if $SendingArgsAndResults` guards.
tshortli
added a commit
to ktoso/swift
that referenced
this pull request
Jul 3, 2024
Supported older compilers don't enable this feature by default, so it can't be omitted from the `_Concurrency` module's flags (regression from swiftlang#74543). Additionally, remove `@_allowFeatureSuppression(IsolatedAny)` from all declarations. We no longer need to support compilers that don't have the `IsolatedAny` feature, so the suppression is superfluous and the alternative branches didn't actually build anyways. _Additionally_, the suppressible feature logic could not handle suppressing `IsolatedAny` simultaneously with `SendingArgsAndResults`, resulting in a broken interface because `sending` was used outside `#if $SendingArgsAndResults` guards.
This was referenced Jul 3, 2024
tshortli
added a commit
to ktoso/swift
that referenced
this pull request
Jul 3, 2024
Supported older compilers don't enable this feature by default, so it can't be omitted from the `_Concurrency` module's flags (regression from swiftlang#74543). Additionally, remove `@_allowFeatureSuppression(IsolatedAny)` from all declarations. We no longer need to support compilers that don't have the `IsolatedAny` feature, so the suppression is superfluous and the alternative branches didn't actually build anyways. _Additionally_, the suppressible feature logic could not handle suppressing `IsolatedAny` simultaneously with `SendingArgsAndResults`, resulting in a broken interface because `sending` was used outside `#if $SendingArgsAndResults` guards.
tshortli
added a commit
to ktoso/swift
that referenced
this pull request
Jul 3, 2024
Supported older compilers don't enable this feature by default, so it can't be omitted from the `_Concurrency` module's flags (regression from swiftlang#74543). Additionally, remove `@_allowFeatureSuppression(IsolatedAny)` from all declarations. We no longer need to support compilers that don't have the `IsolatedAny` feature, so the suppression is superfluous and the alternative branches didn't actually build anyways. _Additionally_, the suppressible feature logic could not handle suppressing `IsolatedAny` simultaneously with `SendingArgsAndResults`, resulting in a broken interface because `sending` was used outside `#if $SendingArgsAndResults` guards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The proposal is accepted and implemented for Swift 6.0.