Disable CMake-based Foundation tests #74589
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
compnerd
reviewed
Jun 20, 2024
|
@swift-ci please smoke test |
parkera
approved these changes
Jun 21, 2024
jmschonfeld
added a commit
to jmschonfeld/swift
that referenced
this pull request
Jun 21, 2024
* Disable old CMake-based Foundation tests * Remove foundation tests from build-windows-toolchain.bat instead of build.ps1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This disables Foundation's (CMake based) unit tests. As we are preparing to land swift-foundation in the toolchain, CMake will no longer be building our unit tests. Instead we will be adding a new phase to the build script after the SwiftPM build to build/run Foundation's unit tests via SwiftPM. For now while we stage that change in, this disables Foundation unit tests so that we can land our new swift-foundation work without breaking CI testing