[cxx-interop][android] link with CxxStdlib when building for Android too #74603
Conversation
|
Still needs a test, but testing on adopters now. |
|
@swift-ci please smoke test |
|
CC @finagolfin |
| case llvm::Triple::Win32: { | ||
| RegistrationCallback( | ||
| LinkLibrary(hasStaticCxxStdlib ? "libswiftCxxStdlib" : "swiftCxxStdlib", | ||
| LibraryKind::Library)); | ||
| break; | ||
| } | ||
| default: | ||
| if (Target.isOSDarwin()) | ||
| if (Target.isOSDarwin() || Target.isOSLinux()) |
There was a problem hiding this comment.
I guess that BSD is still out otherwise it would be nice to collapse this switch.
|
I don't know much about this, as I don't use C++ Interop myself, and never noticed this affecting the Interop tests in the compiler validation suite. Now that you enabled building this library for Android in an earlier pull, I had a problem building this library in Termux with the latest June 13 trunk snapshot because of a C++ Interop error, so I disabled building it again for now, but will try it again soon. If you need it and it works for you, this pull sounds good to me. Speaking of the latest trunk source snapshot, I was finally able to build it and run the compiler validation suite and I'm happy to report that your Bionic modularization fixed a bunch of C++ Interop tests natively in Termux also, once I elided a few Bionic header changes in the Termux app, including the Any reason you haven't submitted your Android stdlib changes for the 6.0 branch yet? |
|
@swift-ci please test |
|
It looks like some of the existing C++ interop runtime tests will cover this for Android. |
|
@swift-ci please test macOS platform |
No description provided.