[PrintAsCxx] Fix printing of C++ enum args #74637
Merged
+95
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beccadax
added
c++ interop
beccadax
requested review from
hyp,
egorzhdan,
hborla,
slavapestov and
xedin
as code owners
|
@swift-ci please test |
beccadax
commented
Jun 21, 2024
| !VD->getAttrs().hasAttribute<ImplementationOnlyAttr>() && | ||
| !isAsyncAlternativeOfOtherDecl(VD) && | ||
| !excludeForObjCImplementation(VD); | ||
| if (VD->isInvalid()) |
There was a problem hiding this comment.
The change to this function is NFC; I simply found the gigantic (and ever-growing, if you look at its version history!) expression hard to understand and even harder to debug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because imported enums are @objc, they were treated as unsupported in C++ and therefore ineligible to be printed in a C++ generated header. Narrow this logic so that only @objc classes are excluded, and update related printing logic to support enums correctly.
Fixes rdar://124262637.