[cxx-interop] ensure that the body of implicit virtual destructor is … #74640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…defined before emitting the clang decl for it This ensures that the destructor definition is emitted into the module's LLVM IR, fixing a linker error.
|
@swift-ci please test |
compnerd
approved these changes
Jun 22, 2024
egorzhdan
reviewed
Jun 24, 2024
lib/IRGen/GenClangDecl.cpp
Outdated
Comment on lines
347
to
348
| assert(!destructor->isDeleted() && | ||
| "Swift cannot handle a type with no known destructor."); |
There was a problem hiding this comment.
Would this assertion fail if struct Base has a deleted destructor but struct Derived : Base defines an explicit destructor? As far as I can see we would currently import Derived into Swift, and then fail with an assertion here.
There was a problem hiding this comment.
Good question. Let me test!
There was a problem hiding this comment.
Yep, this was triggered. I fixed it by adding a check for a deleted destructor before the new invocation path, and added a test too.
hjyamauchi
approved these changes
Jun 24, 2024
hyp
force-pushed
the
eng/virtual-destructor-vtable-ref-irgen-linux-android
branch
from
359565a to
f4949bd
Compare
|
@swift-ci please test |
compnerd
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…defined before emitting the clang decl for it
This ensures that the destructor definition is emitted into the module's LLVM IR, fixing a linker error. The failure can be observed only on a Linux target, like Android, and Darwin/MSVC handle this case just fine.