Skip to content

[cxx-interop] Reenable exporting Foreign Reference Types to C++ #74654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 26, 2024

Conversation

Xazax-hun
Copy link
Contributor

This feature worked prior 5.10 but the semantics was undefined. This PR restores the behavior with the old semantics, and a separate PR will update the documentation to describe the behavior.

rdar://129420670

@Xazax-hun Xazax-hun added the c++ interop Feature: Interoperability with C++ label Jun 24, 2024
@Xazax-hun
Copy link
Contributor Author

@swift-ci please smoke test

This feature worked prior 5.10 but the semantics was undefined. This PR
restores the behavior with the old semantics, and a separate PR will
update the documentation to describe the behavior.
@Xazax-hun Xazax-hun force-pushed the gaborh/reenable-exposing-frts branch from 18c33e4 to 7b72e8f Compare June 24, 2024 17:00
@Xazax-hun
Copy link
Contributor Author

Looks like clang format messed up the test file just before committing it. I need to rerun the tests.

@swift-ci please test

@Xazax-hun Xazax-hun marked this pull request as ready for review June 25, 2024 10:04
@Xazax-hun Xazax-hun requested review from hyp and egorzhdan as code owners June 25, 2024 10:04
Copy link
Contributor

@rjmccall rjmccall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xazax-hun Xazax-hun merged commit 78b0fd7 into main Jun 26, 2024
5 checks passed
@Xazax-hun Xazax-hun deleted the gaborh/reenable-exposing-frts branch June 26, 2024 12:38
Xazax-hun added a commit that referenced this pull request Jun 26, 2024
[cxx-interop] Reenable exporting Foreign Reference Types to C++
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ interop Feature: Interoperability with C++
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants