[6.0] SILGen: Fix emission of 'modify' witness when all generic params are concrete #74669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
tbkka
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixes an assertion failure when emitting a witness table for a conditional conformance making all generic parameters concrete.
Origination: This is a regression in assert builds only, from [6.0] SIL: Consistently drop substitution map when forming apply instructions #74275. The assertion encodes an invariant that was not previously enforced.
Risk: Very low.
Reviewed by: @eeckstein
Issue: Swift 6 compiler crashes while emitting protocol witness #74648.