[6.0] MandatoryPerformanceOptimizations: prevent inlining of dynamic-self class methods #74678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
eeckstein
commented
Jun 25, 2024
eeckstein
commented
- Explanation: This fixes a compiler crash in embedded swift. When a static/global variable is initialized with a class where the initializer uses dynamic Self the MandatoryPerformanceOptimizations crashed while trying to inline the initializer. Such initializer must not be inlined, because the caller (= the global-init function) cannot provide the dynamic-self metadata.
- Scope: Only affects embedded swift.
- Risk: very low. The change prevents inlining for some functions, which are not required to be inlined, anyway.
- Testing: Tested by a test case
- Issue: rdar://129241915
- Reviewer: @kubamracek
- Main branch PR: MandatoryPerformanceOptimizations: prevent inlining of dynamic-self class methods #74657
|
@swift-ci test |
…lass methods This fixes a compiler crash in embedded swift. rdar://129241915
eeckstein
force-pushed
the
fix-mandatory-perf-opt-6.0
branch
from
75a9d8a to
76e3f07
Compare
|
@swift-ci test |
tbkka
approved these changes
Jun 25, 2024
kubamracek
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.